Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: don't use alias methods #14631

Merged
merged 3 commits into from
Oct 26, 2023
Merged

Conversation

G-Rath
Copy link
Contributor

@G-Rath G-Rath commented Oct 20, 2023

Summary

Updates the current docs to not use the aliased methods that are going to be removed in v30 (see ##13164).

I've done a dedicated PR for this to try reduce some of the overall diff of completing #13164 - @SimenB do you think this should be applied to the older docs as well?

Test plan

No tests are needed.

@netlify
Copy link

netlify bot commented Oct 20, 2023

Deploy Preview for jestjs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 67d4199
🔍 Latest deploy log https://app.netlify.com/sites/jestjs/deploys/653a26878dc0c100083ab7ea
😎 Deploy Preview https://deploy-preview-14631--jestjs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@SimenB
Copy link
Member

SimenB commented Oct 23, 2023

@SimenB do you think this should be applied to the older docs as well?

Yeah, that probably makes sense 👍

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wonderful, thanks!

@SimenB SimenB merged commit a91edab into jestjs:main Oct 26, 2023
8 of 9 checks passed
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants