Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(expect): remove alias methods #14632

Merged
merged 6 commits into from
Oct 31, 2023
Merged

Conversation

G-Rath
Copy link
Contributor

@G-Rath G-Rath commented Oct 20, 2023

Summary

Branched off #14631

Resolves #13164
Resolves #13192

I've not updated _landingAnimation.js which uses toThrowError as it has an image which will need to be regenerated and I don't know how to do that

Test plan

The tests have been updated.

@netlify
Copy link

netlify bot commented Oct 20, 2023

Deploy Preview for jestjs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 8967eb5
🔍 Latest deploy log https://app.netlify.com/sites/jestjs/deploys/653e3f8548d6020008659fe6
😎 Deploy Preview https://deploy-preview-14632--jestjs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@SimenB
Copy link
Member

SimenB commented Oct 27, 2023

Could you rebase? 🙂

@G-Rath
Copy link
Contributor Author

G-Rath commented Oct 27, 2023

@SimenB done!

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@SimenB SimenB enabled auto-merge (squash) October 29, 2023 11:17
CHANGELOG.md Outdated Show resolved Hide resolved
@SimenB SimenB disabled auto-merge October 31, 2023 06:39
@SimenB SimenB merged commit eac241c into jestjs:main Oct 31, 2023
72 of 73 checks passed
@SimenB
Copy link
Member

SimenB commented Nov 16, 2023

Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: remove alised matchers
2 participants