Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing testtimeout to intialprojectoptions #14697

Merged
merged 4 commits into from
Nov 16, 2023

Conversation

RayBrokeSomething
Copy link
Contributor

Summary

When defining a testTimeout for projects you receive a CLI message at run time saying the option is valid:

image

Fixes: #14513

Test plan

Copy link

linux-foundation-easycla bot commented Nov 15, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

Copy link

netlify bot commented Nov 15, 2023

Deploy Preview for jestjs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 9d7d06d
🔍 Latest deploy log https://app.netlify.com/sites/jestjs/deploys/6555d8c662269d0008ef8a8c
😎 Deploy Preview https://deploy-preview-14697--jestjs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

adding to type

add missing testtimeout to intialprojectoptions
Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sweet, thanks!

@SimenB SimenB merged commit 9a1e647 into jestjs:main Nov 16, 2023
8 of 9 checks passed
@SimenB
Copy link
Member

SimenB commented Nov 16, 2023

Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Unknown option testTimeout validation warning when used in project specific config
2 participants