Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: split some "jest-snapshot" utility functions to its own package "@jest/snapshot-utils" #15095

Merged
merged 6 commits into from
May 29, 2024

Conversation

connectdotz
Copy link
Contributor

Summary

This PR addresses issue #15036.

Changes include:

  • Moved the specific functions mentioned in the issue, along with any supporting functions and those sharing the same locally defined private constants. This targeted approach minimizes changes and avoids potential circular references, rather than moving the entire utils.ts file.

  • Fixed a few end-to-end (e2e) unit tests that caused yarn test to fail during development. The failures were specifically related to the generation of empty .watchmanconfig files in these tests. With watchman version 2024.05.06.00 on mac, I encountered JSON parsing errors when the config file was blank (rather than containing {} or []). This fix is limited to the occurrences encountered to keep the scope of changes manageable.

Test plan

should not break existing tests

Copy link

linux-foundation-easycla bot commented May 29, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

Copy link

netlify bot commented May 29, 2024

Deploy Preview for jestjs ready!

Name Link
🔨 Latest commit 5ae8cfd
🔍 Latest deploy log https://app.netlify.com/sites/jestjs/deploys/6656c96a46e5a10008037e00
😎 Deploy Preview https://deploy-preview-15095--jestjs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@connectdotz connectdotz changed the title split some "jest-snapshot" utility functions to its own package "@jest/snapshot-utils" feat: split some "jest-snapshot" utility functions to its own package "@jest/snapshot-utils" May 29, 2024
Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@SimenB SimenB merged commit 7a2ccc2 into jestjs:main May 29, 2024
83 of 84 checks passed
@connectdotz connectdotz deleted the snapshot-utils branch May 29, 2024 18:20
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Restore Access to Utility Functions in "jest-snapshot/utils" for Continued Tooling Support
2 participants