-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: split some "jest-snapshot" utility functions to its own package "@jest/snapshot-utils" #15095
Conversation
…t/snapshot-utils"
✅ Deploy Preview for jestjs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
This PR addresses issue #15036.
Changes include:
Moved the specific functions mentioned in the issue, along with any supporting functions and those sharing the same locally defined private constants. This targeted approach minimizes changes and avoids potential circular references, rather than moving the entire utils.ts file.
Fixed a few end-to-end (e2e) unit tests that caused
yarn test
to fail during development. The failures were specifically related to the generation of empty .watchmanconfig files in these tests. With watchman version2024.05.06.00
on mac, I encountered JSON parsing errors when the config file was blank (rather than containing{}
or[]
). This fix is limited to the occurrences encountered to keep the scope of changes manageable.Test plan
should not break existing tests