Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove handling of babelrc in jest-editor-support #3344

Merged
merged 1 commit into from
Apr 21, 2017
Merged

Remove handling of babelrc in jest-editor-support #3344

merged 1 commit into from
Apr 21, 2017

Conversation

danez
Copy link
Contributor

@danez danez commented Apr 21, 2017

Summary

.babelrc is the config file of babel and not babylon. Loading plugins from .babelrc and supplying them to babylon does nothing. babylon will not fail but silently ignore invalid plugins.

In future we want to have a way to use .babelrc (or similar) for babylon, but we are not there yet.

I noticed this while searching for why vscode-jest does not work with jsx syntax, but this is due to #3076 not being released yet.

//cc @orta

babelrc is the config file of babel and not babylon
@codecov-io
Copy link

Codecov Report

Merging #3344 into master will decrease coverage by 0.11%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3344      +/-   ##
==========================================
- Coverage   65.04%   64.93%   -0.12%     
==========================================
  Files         176      176              
  Lines        6535     6514      -21     
  Branches        4        4              
==========================================
- Hits         4251     4230      -21     
  Misses       2283     2283              
  Partials        1        1
Impacted Files Coverage Δ
...s/jest-editor-support/src/parsers/BabylonParser.js 98.64% <100%> (-0.3%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f47aa3...a5e7477. Read the comment docs.

@cpojer cpojer merged commit a9288e4 into jestjs:master Apr 21, 2017
@cpojer
Copy link
Member

cpojer commented Apr 21, 2017

This is great, I was hoping for this change for a while but nobody got around to it. Thank you very much.

@danez danez deleted the remove-babel-plugins branch April 21, 2017 17:43
@orta
Copy link
Member

orta commented Apr 21, 2017

Ah - thanks! Will ship an update to vscode-jest once there's another Jest release - should fix a bunch of stuff 👍

skovhus pushed a commit to skovhus/jest that referenced this pull request Apr 29, 2017
babelrc is the config file of babel and not babylon
tushardhole pushed a commit to tushardhole/jest that referenced this pull request Aug 21, 2017
babelrc is the config file of babel and not babylon
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants