Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support setting returnvalue from mock to undefined #3354

Merged
merged 1 commit into from
Apr 25, 2017

Conversation

SimenB
Copy link
Member

@SimenB SimenB commented Apr 23, 2017

Summary
Fixes #3320

Test plan
yarn jest

@SimenB
Copy link
Member Author

SimenB commented Apr 23, 2017

SegFault on CI, but I'm not allowed to restart it. EDIT: Someone did 😄

@codecov-io
Copy link

Codecov Report

Merging #3354 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3354      +/-   ##
==========================================
+ Coverage   64.93%   64.94%   +<.01%     
==========================================
  Files         176      176              
  Lines        6514     6515       +1     
  Branches        4        4              
==========================================
+ Hits         4230     4231       +1     
  Misses       2283     2283              
  Partials        1        1
Impacted Files Coverage Δ
packages/jest-mock/src/index.js 91.85% <100%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9288e4...db657c7. Read the comment docs.

@cpojer cpojer merged commit f465fb6 into jestjs:master Apr 25, 2017
@SimenB SimenB deleted the mock-undefined branch April 25, 2017 11:14
tushardhole pushed a commit to tushardhole/jest that referenced this pull request Aug 21, 2017
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mockReturnValueOnce ignores calls with undefined (docs should say so)
4 participants