-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
compare objects with Symbol keys #3437
compare objects with Symbol keys #3437
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3437 +/- ##
==========================================
- Coverage 64.02% 63.99% -0.04%
==========================================
Files 177 177
Lines 6580 6574 -6
Branches 5 5
==========================================
- Hits 4213 4207 -6
Misses 2365 2365
Partials 2 2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is good to go, but we need to refactor these jasmine utils later. There's a lot of code we can remove.
@thymikee any update with this PR? do you prefer to refactor the jasmine utils first? I so, I can help with some guidance on what needs to be refactored. |
Jasmine is already being rewritten into something better by @DmitriiAbramov so no need for that :). Utils will probably stay the same, but refactor can be postponed. Just wait for him or @cpojer to get their eyes on this. |
* compare objects with Symbol keys * Update symbol-in-objects-test.js
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Fixes #3347
I'm using
Object.getOwnPropertySymbols
to get theSymbol
keysTest plan
yarn test