Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve and consolidate config resolution. #3472

Merged
merged 1 commit into from
May 5, 2017

Conversation

cpojer
Copy link
Member

@cpojer cpojer commented May 4, 2017

Summary

This allows --projects to take either a js file, a json file, a package.json file or any folder where it will traverse the tree to find a jest.config.js or package.json file. Also enabled me to roll up the function to find configs into a single one.

Test plan

  • Tried it at FB.
  • Modified yarn test-examples to have a mix of directory names and configs specified in package.json.
  • Totally still needs an integration test. #yolo

@codecov-io
Copy link

Codecov Report

Merging #3472 into master will decrease coverage by 2.15%.
The diff coverage is 10.52%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3472      +/-   ##
==========================================
- Coverage   64.39%   62.23%   -2.16%     
==========================================
  Files         182      181       -1     
  Lines        6695     6692       -3     
  Branches        5        5              
==========================================
- Hits         4311     4165     -146     
- Misses       2382     2525     +143     
  Partials        2        2
Impacted Files Coverage Δ
packages/jest-config/src/normalize.js 90.8% <ø> (ø) ⬆️
packages/jest-config/src/index.js 36.36% <0%> (-2.77%) ⬇️
packages/jest-config/src/findConfig.js 20% <11.76%> (-8.58%) ⬇️
packages/jest-config/src/vendor/jsonlint.js 5.72% <0%> (-50%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 829531f...7deb039. Read the comment docs.

@aaronabramov aaronabramov merged commit e9e7772 into jestjs:master May 5, 2017
tushardhole pushed a commit to tushardhole/jest that referenced this pull request Aug 21, 2017
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2021
@cpojer cpojer deleted the config-resolution branch October 18, 2022 02:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants