Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call consistent pretty-format plugins within Jest #3800

Merged
merged 1 commit into from
Jun 27, 2017

Conversation

pedrottimark
Copy link
Contributor

Summary

  • Add ReactTestComponent to jest-matcher-utils
  • Call the most frequently used plugins first.

Please confirm that AsymmetricMatcher is for jest-diff and jest-matcher-utils but not jest-snapshot

Test plan

Jest

@codecov-io
Copy link

Codecov Report

Merging #3800 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3800   +/-   ##
=======================================
  Coverage   57.58%   57.58%           
=======================================
  Files         194      194           
  Lines        6776     6776           
  Branches        6        6           
=======================================
  Hits         3902     3902           
  Misses       2871     2871           
  Partials        3        3
Impacted Files Coverage Δ
packages/jest-diff/src/index.js 65.21% <ø> (ø) ⬆️
packages/jest-matcher-utils/src/index.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03bb9b3...3020959. Read the comment docs.

@cpojer cpojer merged commit bd897bf into jestjs:master Jun 27, 2017
@pedrottimark pedrottimark deleted the consistent-plugins branch June 27, 2017 19:35
tushardhole pushed a commit to tushardhole/jest that referenced this pull request Aug 21, 2017
@pedrottimark
Copy link
Contributor Author

For the record, pictures of React test object from Jest 20 before and Jest 21 after this change:

before

after

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants