Separated the snapshot summary creation from the printing to improve testability. #4373
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the coverage for the jest-cli reporters was not very high so I decided I could add some value by writing some tests for it:)
I split the creation of the snapshot summary to a separate file (
get_snapshot_summary.js
).I wanted to write a test for the snapshot summary text printed in the console at the end of a text. However, the
summary_reporter.js
in which the snapshot summary creation is contained requires a lot of overhead to set up making focused testing difficult. This is why I split the creation of the snapshot summary from the reporting about it.I am hoping that test coverage of the reporters can be gradually improved by splitting them up into smaller units with well defined and focused responsibilities that are easily testable.
Let me know what you think!