fix: Reset local state of assertions when using hasAssertions #4498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice! |
|
From the looks of it this fixes #3595 too and will also fix this issue in babel-jest-assertions I just debugged the issue all the way to find the state not being reset and was about to open a PR and then found this one 😆 nice one @thymikee! At least I have a bit of a better understanding of how Jest works now 😄 @cpojer Do you know when this will be released? |
|
This week. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
.hasAssertionsleaked to everytestcase following the one it was declared in.Also decided to extract
setStatecall to a function namedresetAssertionsStateso it's easier to understand what it does.Fixes #4496.
Test plan
Empty test without assertions. Fails on current master.