Simplify highlight for leading and trailing spaces in jest-diff

[pedrottimark]

Summary

• Replace explicit background colors with inverse for removed, added, in-changed lines.
• Mid-course change: add bgYellow for unchanged lines which didn’t have highlight. The dim stack trace and gray lines caused a perceptual conflict instead of a contrast. Also as Scott said, gray was not light enough. I think yellow looks better on Windows. It looks like pollen on the following illustrations from MacOS Terminal. Also better not to churn snapshots of diffs.

Removed lines are bgGreen at left and inverse of green at right, that is the same:

Added lines are bgRed at left and inverse of red at right, that is the same:

Indentation-changed lines are bgCyan at left and inverse of cyan at right, that is the same:

Unchanged lines are unhighlighted at left and bgYellow at right:

Thank y’all for reviewing incremental improvements even when urgent problems need solutions.

Next: similar change in jest-matcher-utils but a few things puzzled me in expect

Test plan

Updated 4 snapshot in 1 test suite (renamed one of them)

P.S. Give my thanks to the Yarn team for improved links so previous PR passed AppVeyor CI

[codecov-io]

Codecov Report

Merging #4553 into master will decrease coverage by 0.02%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #4553      +/-   ##
==========================================
- Coverage   56.04%   56.01%   -0.03%     
==========================================
  Files         185      185              
  Lines        6268     6264       -4     
  Branches        3        3              
==========================================
- Hits         3513     3509       -4     
  Misses       2754     2754              
  Partials        1        1

Impacted Files	Coverage Δ
packages/jest-diff/src/diff_strings.js	98.83% <100%> (-0.06%)	⬇️
packages/pretty-format/src/plugins/convert_ansi.js	100% <100%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23c1e10...be0e2fe. Read the comment docs.

[cpojer]

super awesome.

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.