docs: mention about optional done argument in test fn
#4556
Conversation
I've run into an issue that my test hangs because I've defined the parameter for the test callback. Could be handy to mention that.
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
Codecov Report
@@ Coverage Diff @@
## master #4556 +/- ##
=======================================
Coverage 56.03% 56.03%
=======================================
Files 185 185
Lines 6267 6267
Branches 3 3
=======================================
Hits 3512 3512
Misses 2754 2754
Partials 1 1Continue to review full report at Codecov.
|
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
thymikee
changed the title
Test. Added mention about optional done argumentdone argument in test fn
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
Nice update! This is a good clarification. |
* docs(testAPI): mention about optional `done` argument I've run into an issue that my test hangs because I've defined the parameter for the test callback. Could be handy to mention that. * Update GlobalAPI.md
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Updated general API docs. I've missed mention about an optional parameter of the test function.
I've run into an issue that my test hangs because I've defined the parameter for the test callback. Could be handy to mention that.