Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix editor support test for node 4 #4640

Merged
merged 1 commit into from
Oct 9, 2017
Merged

Conversation

SimenB
Copy link
Member

@SimenB SimenB commented Oct 9, 2017

Summary
Node 4 test suite is broken. Why the Circle CI badge is green in the readme is beyond me 😕 Something odd with Circle 2?

/cc @orta

image

fancy

Test plan
CI for node 4 should be green.

@cpojer
Copy link
Member

cpojer commented Oct 9, 2017

oh yeah!

@cpojer
Copy link
Member

cpojer commented Oct 9, 2017

We should probably drop node 4 soon.

@SimenB SimenB deleted the fix-tests-node-4 branch October 9, 2017 19:46
@SimenB
Copy link
Member Author

SimenB commented Oct 9, 2017

Do a 22 once node 8 hits LTS? It's due later this month

@cpojer
Copy link
Member

cpojer commented Oct 9, 2017

Sounds like a great plan.

@orta
Copy link
Member

orta commented Oct 9, 2017

👍

@codecov-io
Copy link

Codecov Report

Merging #4640 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4640   +/-   ##
=======================================
  Coverage   57.12%   57.12%           
=======================================
  Files         194      194           
  Lines        6566     6566           
  Branches        3        3           
=======================================
  Hits         3751     3751           
  Misses       2815     2815
Impacted Files Coverage Δ
packages/jest-editor-support/src/Snapshot.js 98.07% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dfbfaa0...39360a2. Read the comment docs.

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants