-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix editor support test for node 4 #4640
Conversation
oh yeah! |
We should probably drop node 4 soon. |
Do a 22 once node 8 hits LTS? It's due later this month |
Sounds like a great plan. |
👍 |
Codecov Report
@@ Coverage Diff @@
## master #4640 +/- ##
=======================================
Coverage 57.12% 57.12%
=======================================
Files 194 194
Lines 6566 6566
Branches 3 3
=======================================
Hits 3751 3751
Misses 2815 2815
Continue to review full report at Codecov.
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Node 4 test suite is broken. Why the Circle CI badge is green in the readme is beyond me 😕 Something odd with Circle 2?
/cc @orta
fancy
Test plan
CI for node 4 should be green.