-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a serializer for jest.fn to jest-snapshot #4668
Conversation
They don't seem as useful as I though
This is clever, I like it. Let's do it. |
Codecov Report
@@ Coverage Diff @@
## master #4668 +/- ##
==========================================
- Coverage 57.13% 57.13% -0.01%
==========================================
Files 194 195 +1
Lines 6565 6569 +4
Branches 3 3
==========================================
+ Hits 3751 3753 +2
- Misses 2814 2816 +2
Continue to review full report at Codecov.
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
This adds a serializer to be able to easily assert on the calls of a mock.
This is very easy to implement in userland, so I understand if it's not merged 🙂 But it's been useful for me, so maybe it'll be useful for others?
(I started creating a separate module for this, but I got annoyed that I couldn't use
mock.getMockName()
, so here's a PR)Test plan
New tests added