adds missing node builtin modules to jest-resolve package #4740
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the usage of the
is-builtin-module
dependency in thejest-resolve
package to utilize a less strict method of checking for builtin node dependencies.The change is to fix #4677 which causes jest to break when any node package is making use of a builtin filtered out by the
is-builtin-module
package. The author has made clear that they will not include the packages so jest should not be utilizing this package any longer.Using the following repo to test for the issue
Before
After the fix is in place