-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add prefer-to-have-length rule to eslint-plugin-jest package #4771
Conversation
I like it, but I'm guessing @cpojer would prefer to not have it bundled. If he does not want it, I suggest we create an (there are more rules I'd like that are more nice-to-haves than anything else) |
d518e11
to
34de38e
Compare
I like it also, actually. This makes sense to me for better failure messages. |
d37e434
to
4127fbe
Compare
Codecov Report
@@ Coverage Diff @@
## master #4771 +/- ##
=========================================
+ Coverage 58.94% 59% +0.06%
=========================================
Files 199 200 +1
Lines 6630 6626 -4
Branches 3 4 +1
=========================================
+ Hits 3908 3910 +2
+ Misses 2722 2716 -6
Continue to review full report at Codecov.
|
4127fbe
to
85f03b9
Compare
@xfumihiro Can you make this, and the others you sent (woo! thanks!), fixable? Should be straightforward 🙂 |
85f03b9
to
928286a
Compare
928286a
to
c6ca332
Compare
@SimenB Done |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
No description provided.