-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
don't let source-map-support use xhr - 25-75% speed improvement #5045
Conversation
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
Will edit changelog soon. |
Codecov Report
@@ Coverage Diff @@
## master #5045 +/- ##
=======================================
Coverage 60.74% 60.74%
=======================================
Files 198 198
Lines 6605 6605
Branches 4 4
=======================================
Hits 4012 4012
Misses 2593 2593
Continue to review full report at Codecov.
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
Wow that's weird. Awesome fix, thanks for sending a PR :) |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
When jsdom is installed, source-map-support does this:
https://github.com/evanw/node-source-map-support/blob/master/source-map-support.js#L110
Which for me caused a massive slowdown. With this patch my tests go from 99s to 74s to run and an individual test suite 16s to 4s.
Test plan
Jest can only run in node - I am not sure this needs tests?