Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't let source-map-support use xhr - 25-75% speed improvement #5045

Merged
merged 3 commits into from
Dec 11, 2017

Conversation

lukeapage
Copy link
Contributor

Summary

When jsdom is installed, source-map-support does this:
https://github.com/evanw/node-source-map-support/blob/master/source-map-support.js#L110

Which for me caused a massive slowdown. With this patch my tests go from 99s to 74s to run and an individual test suite 16s to 4s.

Test plan

Jest can only run in node - I am not sure this needs tests?

@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@lukeapage lukeapage changed the title don't let source-map-support use xhr don't let source-map-support use xhr - 25-75% speed improvement w/ jsdom Dec 10, 2017
@lukeapage lukeapage changed the title don't let source-map-support use xhr - 25-75% speed improvement w/ jsdom don't let source-map-support use xhr - 25-75% speed improvement Dec 10, 2017
@lukeapage
Copy link
Contributor Author

Will edit changelog soon.

@codecov-io
Copy link

codecov-io commented Dec 10, 2017

Codecov Report

Merging #5045 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5045   +/-   ##
=======================================
  Coverage   60.74%   60.74%           
=======================================
  Files         198      198           
  Lines        6605     6605           
  Branches        4        4           
=======================================
  Hits         4012     4012           
  Misses       2593     2593
Impacted Files Coverage Δ
packages/jest-jasmine2/src/index.js 5.97% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c4399b...d2d1190. Read the comment docs.

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@cpojer cpojer merged commit 34bd3bb into jestjs:master Dec 11, 2017
@cpojer
Copy link
Member

cpojer commented Dec 11, 2017

Wow that's weird. Awesome fix, thanks for sending a PR :)

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants