Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix npm update command for snapshot summary #5376

Merged
merged 3 commits into from
Jan 24, 2018

Conversation

kdnakt
Copy link
Contributor

@kdnakt kdnakt commented Jan 23, 2018

Summary

The snapshot summary told me to use npm test -u but it didn't work and needs special option -- to update snapshot.
This fix tells the correct command to update snapshot for npm.

Test plan

With npm test, I got this summary.
2018-01-24 2 14 37

With yarn test.
2018-01-24 2 15 05

@codecov-io
Copy link

codecov-io commented Jan 23, 2018

Codecov Report

Merging #5376 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5376      +/-   ##
==========================================
- Coverage   61.33%   61.32%   -0.01%     
==========================================
  Files         205      205              
  Lines        6924     6925       +1     
  Branches        3        4       +1     
==========================================
  Hits         4247     4247              
- Misses       2676     2677       +1     
  Partials        1        1
Impacted Files Coverage Δ
...ackages/jest-cli/src/reporters/summary_reporter.js 14.75% <0%> (-0.25%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fec36ae...d7473dd. Read the comment docs.

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@cpojer cpojer merged commit 4080d98 into jestjs:master Jan 24, 2018
@cpojer
Copy link
Member

cpojer commented Jan 24, 2018

This is an awesome tiny fix. Thanks for sending a PR.

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants