-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[jest-each] Refactor logic #6345
Conversation
b12cb20
to
ea130dc
Compare
Nice cleanup! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
niiiiiice
Codecov Report
@@ Coverage Diff @@
## master #6345 +/- ##
==========================================
- Coverage 63.89% 63.63% -0.27%
==========================================
Files 228 226 -2
Lines 8705 8648 -57
Branches 4 4
==========================================
- Hits 5562 5503 -59
- Misses 3142 3144 +2
Partials 1 1
Continue to review full report at Codecov.
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
This PR refactors the jest-each library to use the shared
bind
logic integral to Jest's core.This way we have only one implementation and the changes propagate to all instances of the
each
logicTest plan
Tests should still pass