[babel-plugin-jest-hoist] Fix MockNativeMethods access in react-native #6505

timwangdev · 2018-06-20T07:46:29Z

Summary

Fix facebook/react-native#19120
Fix #6504

Test plan

/e2e/babel-plugin-jest-hoist/__tests__/integration.test.js

thymikee · 2018-06-20T07:48:33Z

Might adding a changelog and updating an e2e test?

SimenB · 2018-06-20T07:51:27Z

packages/babel-plugin-jest-hoist/src/index.js

@@ -110,7 +110,7 @@ FUNCTIONS.mock = args => {
      if (!found) {
        invariant(
          (scope.hasGlobal(name) && WHITELISTED_IDENTIFIERS[name]) ||
-            /^mock/.test(name) ||
+            /^[Mm]ock/.test(name) ||


/^mock/i? MOCK_THING should be fine as well, IMO.

Should also update the message on line 126

SimenB

See inline comments

SimenB · 2018-06-20T08:03:44Z

packages/babel-plugin-jest-hoist/src/index.js

@@ -71,7 +71,7 @@ const WHITELISTED_IDENTIFIERS = {
 };
 Object.keys(global).forEach(name => (WHITELISTED_IDENTIFIERS[name] = true));

-const JEST_GLOBAL = {name: 'jest'};
+const JEST_GLOBAL = { name: 'jest' };


I think your IDE autoformatted?

Hmm, I guess is this one https://github.com/facebook/jest/blob/master/.vscode/settings.json#L8
Reverted.

codecov-io · 2018-06-20T08:11:10Z

Codecov Report

Merging #6505 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #6505   +/-   ##
=======================================
  Coverage   63.48%   63.48%           
=======================================
  Files         227      227           
  Lines        8697     8697           
  Branches        3        3           
=======================================
  Hits         5521     5521           
  Misses       3175     3175           
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4805134...366cb5b. Read the comment docs.

macrozone · 2018-06-24T13:16:40Z

are we able to install that? can't run tests under react-native 0.56 without that :-/

refering to a commit-url in package.json does not work unfortunatly

emilkarl · 2018-06-25T12:51:04Z

When will this be released?

thymikee · 2018-06-25T12:51:56Z

cc @mjesun @SimenB, we should be good to make a minor release

SimenB · 2018-06-25T13:19:22Z

I'd like for #6523 to land first (#6498 would also be nice), but I agree this should see a release

mjesun · 2018-06-25T13:21:11Z

👌🏻 Let me know when you want the release to be done and we'll make it 🙂

SimenB · 2018-06-25T13:22:26Z

You can land #6523 and do it? 😀

mjesun · 2018-06-25T13:31:20Z

#6523 is b0rken, is it OK to land?

SimenB · 2018-06-25T13:32:27Z

Yeah, CI was fixed after that was opened in #6532

mjesun · 2018-06-25T13:57:29Z

Roger that!

This Pull Request updates dependency [jest](https://github.com/facebook/jest) from `v23.1.0` to `v23.2.0` <details> <summary>Release Notes</summary> ### [`v23.2.0`](https://github.com/facebook/jest/blob/master/CHANGELOG.md#2320) [Compare Source](jestjs/jest@v23.1.0...v23.2.0) ##### Features - `[jest-each]` Add support for keyPaths in test titles ([#6457](`https://github.com/facebook/jest/pull/6457`)) - `[jest-cli]` Add `jest --init` option that generates a basic configuration file with a short description for each option ([#6442](`https://github.com/facebook/jest/pull/6442`)) - `[jest.retryTimes]` Add `jest.retryTimes()` option that allows failed tests to be retried n-times when using jest-circus. ([#6498](`https://github.com/facebook/jest/pull/6498`)) ##### Fixes - `[jest-cli]` Add check to make sure one or more tests have run before notifying when using `--notify` ([#6495](`https://github.com/facebook/jest/pull/6495`)) - `[jest-cli]` Pass `globalConfig` as a parameter to `globalSetup` and `globalTeardown` functions ([#6486](`https://github.com/facebook/jest/pull/6486`)) - `[jest-config]` Add missing options to the `defaults` object ([#6428](`https://github.com/facebook/jest/pull/6428`)) - `[expect]` Using symbolic property names in arrays no longer causes the `toEqual` matcher to fail ([#6391](`https://github.com/facebook/jest/pull/6391`)) - `[expect]` `toEqual` no longer tries to compare non-enumerable symbolic properties, to be consistent with non-symbolic properties. ([#6398](`https://github.com/facebook/jest/pull/6398`)) - `[jest-util]` `console.timeEnd` now properly log elapsed time in milliseconds. ([#6456](`https://github.com/facebook/jest/pull/6456`)) - `[jest-mock]` Fix `MockNativeMethods` access in react-native `jest.mock()` ([#6505](`https://github.com/facebook/jest/pull/6505`)) ##### Chore & Maintenance - `[docs]` Add jest-each docs for 1 dimensional arrays ([#6444](`https://github.com/facebook/jest/pull/6444`/files)) --- </details> --- This PR has been generated by [Renovate Bot](https://renovatebot.com).

Tests have started failing (see [Build #699](https://travis-ci.org/okta/okta-oidc-js/builds/401943311)). I tried upgrading the jest and/or the babel plugins, per these threads: facebook/react-native#19859 jestjs/jest#6505 But I didn't have any luck. Locking to the 0.55 series of react-ntaive does seeem to fix this problem

Tests have started failing (see [Build #699](https://travis-ci.org/okta/okta-oidc-js/builds/401943311)). I tried upgrading the jest and/or the babel plugins, per these threads: facebook/react-native#19859 jestjs/jest#6505 But I didn't have any luck. Locking to the 0.55 series of react-native does seem to fix this problem

evanjmg · 2018-07-22T15:28:29Z

Is this fixed? I'm still getting the error with Jest 23.4.1.

UPDATE: I needed to make sure Babel-jest was up to date to inherit this.

Tests have started failing (see [Build #699](https://travis-ci.org/okta/okta-oidc-js/builds/401943311)). I tried upgrading the jest and/or the babel plugins, per these threads: facebook/react-native#19859 jestjs/jest#6505 But I didn't have any luck. Locking to the 0.55 series of react-native does seem to fix this problem

github-actions · 2021-05-12T11:07:05Z

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

Fix MockNativeMethods access in react-native

02361c7

facebook-github-bot added the cla signed label Jun 20, 2018

SimenB reviewed Jun 20, 2018

View reviewed changes

SimenB requested changes Jun 20, 2018

View reviewed changes

Tim Wang and others added 3 commits June 20, 2018 15:57

Update changelog and RegExp

29a6bf0

Update error message

afaf802

Update CHANGELOG.md

f6f29c2

SimenB reviewed Jun 20, 2018

View reviewed changes

Reverted code format

5e816ff

Add mock variable name test

366cb5b

SimenB approved these changes Jun 20, 2018

View reviewed changes

thymikee approved these changes Jun 20, 2018

View reviewed changes

cpojer merged commit 49d7bbf into jestjs:master Jun 20, 2018

timwangdev deleted the patch-1 branch June 20, 2018 18:19

timwangdev mentioned this pull request Jun 25, 2018

Can't run jest tests with 0.56.0 facebook/react-native#19859

Closed

3 tasks

dependencies bot mentioned this pull request Jun 25, 2018

Update babel-jest in / from 21.2.0 to 23.2.0 pcardune/redux-firebase-mirror#133

Open

This was referenced Jul 2, 2018

Update jest in / from 21.2.1 to 23.2.0 LibreTubeApp/LibreTube#122

Open

Update jest in / from 23.1.0 to 23.2.0 opencomponents/storage-adapters#76

Merged

robertjd mentioned this pull request Jul 9, 2018

fix[okta-react-native]: Lock to 0.55.4, add package-lock okta/okta-oidc-js#239

Merged

javamonn mentioned this pull request Oct 31, 2018

Port Relay test tooling from Reaction, update to Node 10 artsy/emission#1209

Merged

dependencies bot mentioned this pull request Nov 1, 2018

Update jest in / from 22.1.4 to 23.6.0 leonardofaria/leozera-ui#250

Closed

Haroenv mentioned this pull request Aug 9, 2019

fix(deps): update react monorepo algolia/react-instantsearch#2746

Closed

1 task

snyk-bot mentioned this pull request Mar 17, 2020

[Snyk] Upgrade expect from 23.0.0 to 23.6.0 yowainwright/react-workshop#8

Merged

github-actions bot locked as resolved and limited conversation to collaborators May 12, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[babel-plugin-jest-hoist] Fix MockNativeMethods access in react-native #6505

[babel-plugin-jest-hoist] Fix MockNativeMethods access in react-native #6505

timwangdev commented Jun 20, 2018 •

edited

Loading

thymikee commented Jun 20, 2018

SimenB Jun 20, 2018

SimenB Jun 20, 2018

timwangdev Jun 20, 2018

SimenB left a comment

SimenB Jun 20, 2018

timwangdev Jun 20, 2018

codecov-io commented Jun 20, 2018 •

edited

Loading

macrozone commented Jun 24, 2018

emilkarl commented Jun 25, 2018

thymikee commented Jun 25, 2018

SimenB commented Jun 25, 2018

mjesun commented Jun 25, 2018

SimenB commented Jun 25, 2018

mjesun commented Jun 25, 2018

SimenB commented Jun 25, 2018

mjesun commented Jun 25, 2018 •

edited

Loading

evanjmg commented Jul 22, 2018 •

edited

Loading

github-actions bot commented May 12, 2021

[babel-plugin-jest-hoist] Fix MockNativeMethods access in react-native #6505

[babel-plugin-jest-hoist] Fix MockNativeMethods access in react-native #6505

Conversation

timwangdev commented Jun 20, 2018 • edited Loading

Summary

Test plan

thymikee commented Jun 20, 2018

SimenB Jun 20, 2018

Choose a reason for hiding this comment

SimenB Jun 20, 2018

Choose a reason for hiding this comment

timwangdev Jun 20, 2018

Choose a reason for hiding this comment

SimenB left a comment

Choose a reason for hiding this comment

SimenB Jun 20, 2018

Choose a reason for hiding this comment

timwangdev Jun 20, 2018

Choose a reason for hiding this comment

codecov-io commented Jun 20, 2018 • edited Loading

Codecov Report

macrozone commented Jun 24, 2018

emilkarl commented Jun 25, 2018

thymikee commented Jun 25, 2018

SimenB commented Jun 25, 2018

mjesun commented Jun 25, 2018

SimenB commented Jun 25, 2018

mjesun commented Jun 25, 2018

SimenB commented Jun 25, 2018

mjesun commented Jun 25, 2018 • edited Loading

evanjmg commented Jul 22, 2018 • edited Loading

github-actions bot commented May 12, 2021

timwangdev commented Jun 20, 2018 •

edited

Loading

codecov-io commented Jun 20, 2018 •

edited

Loading

mjesun commented Jun 25, 2018 •

edited

Loading

evanjmg commented Jul 22, 2018 •

edited

Loading