Fix "should_instrument" decision when given negative testMatch pattern #7170
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Files that match with the
testFiles
configuration aren't instrumented for test coverage.This check was being done with
multimatch.any
which behaves unexpectedly when given an inverse glob pattern (!**/dont/**/*.js
).Issue: #7165
Reproduction: https://github.com/g-harel/jest-7165
Test plan
I've modified an existing test case to verify that the fix works.
I also linked my local fork to the reproduction project to confirm that the change had the intended effect.