Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "should_instrument" decision when given negative testMatch pattern #7170

Merged
merged 1 commit into from
Oct 16, 2018

Conversation

g-harel
Copy link
Contributor

@g-harel g-harel commented Oct 15, 2018

Summary

Files that match with the testFiles configuration aren't instrumented for test coverage.

This check was being done with multimatch.any which behaves unexpectedly when given an inverse glob pattern (!**/dont/**/*.js).

Issue: #7165
Reproduction: https://github.com/g-harel/jest-7165

Test plan

I've modified an existing test case to verify that the fix works.

I also linked my local fork to the reproduction project to confirm that the change had the intended effect.

@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the changelog?

@g-harel g-harel force-pushed the should-instrument-negative-glob branch from 0db96b3 to f0a8fab Compare October 15, 2018 20:44
@g-harel
Copy link
Contributor Author

g-harel commented Oct 15, 2018

@SimenB done ✔️

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants