Standardize filenames in packages/expect #7306
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
References Standardize file naming #4969.
Updates naming in package expect. Uses conventions listed in #4969 (comment):
Decisions
matchers.js
jestMatchersObject.js
spyMatchers.js
toThrowmatchers.js
Questions
How should
asymmetricMatchers.js
be named? It exports a classAsymmetricMatcher
, but it also exports a bunch of functions, and was named in camelCase before.Test plan
Output of yarn run test on master and standardize filenames in packages/jest circus branches was the same.
jest-test-expect-master.txt
jest-test-expect-standardize-filenames.txt