rollback write-file-atomic #7725
Conversation
| @@ -28,8 +28,8 @@ | |||
| "micromatch": "^3.1.10", | |||
| "realpath-native": "^1.0.0", | |||
| "slash": "^2.0.0", | |||
| "strip-bom": "3.0.0", | |||
| "write-file-atomic": "^2.4.2", | |||
| "strip-bom": "^3.0.0", | |||
There was a problem hiding this comment.
Ignore this, I just noticed it
Codecov Report
@@ Coverage Diff @@
## master #7725 +/- ##
=======================================
Coverage 68.27% 68.27%
=======================================
Files 252 252
Lines 9682 9682
Branches 5 5
=======================================
Hits 6610 6610
Misses 3070 3070
Partials 2 2Continue to review full report at Codecov.
|
|
It fixed the cache write error. Not sure why it hangs on attempting to detect open handles, though... |
|
I am seeing hangs on build machines with 2.4.1 too (though can confirm it fixes the errors) |
|
Yeah, this is just a temp thing, hopefully it's fixed upstream (I got a response on the comment linked in the OP) |
|
When upstream comes out with a fix, we can upgrade again, but I think I'm gonna land this in the meantime |
|
@SimenB any idea when this will be published? |
|
No, sorry. The people making releases are super busy now, but I hope we can get a release out soon. (although I cannot tell you what "soon" means) |
|
24.1.0 is released |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Closes #7709. We're also seeing this error in CI, e.g. https://dev.azure.com/jestjs/jest/_build/results?buildId=264
I think this is caused by npm/write-file-atomic@3365a4d
EDIT: If that's the case, 2.4.1 should be safe actually. Lemme try that.
Test plan
Green Windows build on azure.