Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setup building, linting and testing of TypeScript #7808

Merged
merged 6 commits into from
Feb 6, 2019
Merged

Setup building, linting and testing of TypeScript #7808

merged 6 commits into from
Feb 6, 2019

Conversation

SimenB
Copy link
Member

@SimenB SimenB commented Feb 5, 2019 •
edited
Loading

Summary

This PR makes the necessary changes to our development setup in order for us to start migrating to TypeScript. It's a prerequisite for #7807

Test plan

Green CI, hopefully 🤞 (EDIT: well, that didn't work out 😅 EDIT2: There we go)

This was referenced Feb 5, 2019
Merged
Closed
@SimenB SimenB added this to the TypeScript Migration milestone Feb 5, 2019
@SimenB
skip tsc run if there are no packages to compile
7b08165 
Will revert this when we actually have some
@merlinnot
Copy link

What do you think about using TSLint instead of ESLint?

@SimenB
Copy link
Member Author

SimenB commented Feb 5, 2019 •
edited
Loading

What do you think about using TSLint instead of ESLint?

TypeScript itself is moving to eslint:

@merlinnot
Copy link

Oh, that's really good to know, thanks. No more questions 👍

cpojer
cpojer approved these changes Feb 6, 2019
View reviewed changes
Copy link
Member

@cpojer cpojer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice prep work!

thymikee
thymikee approved these changes Feb 6, 2019
View reviewed changes
Copy link
Collaborator

@thymikee thymikee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@SimenB SimenB merged commit d792940 into jestjs:master Feb 6, 2019
@SimenB SimenB deleted the typescript branch February 6, 2019 09:18
captain-yossarian pushed a commit to captain-yossarian/jest that referenced this pull request Jul 18, 2019
@SimenB @captain-yossarian
Setup building, linting and testing of TypeScript (jestjs#7808)
304c0f5
@snyk-bot snyk-bot mentioned this pull request Dec 15, 2019
Open
This was referenced Mar 21, 2020
Closed
Merged
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@thymikee thymikee thymikee approved these changes

@cpojer cpojer cpojer approved these changes

@orta orta Awaiting requested review from orta

@rubennorte rubennorte Awaiting requested review from rubennorte

Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
TypeScript Migration
Development

Successfully merging this pull request may close these issues.
5 participants
@SimenB @merlinnot @cpojer @thymikee @facebook-github-bot