Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: print error msg & stack on preset normalization error #7935

Merged
merged 1 commit into from
Feb 19, 2019

Conversation

wtho
Copy link
Contributor

@wtho wtho commented Feb 19, 2019

Summary

When loading a jest-preset.js, which does some computation or load other packages, errors can occur.

This PR will help preset-developers to see the error message and stack. Currently only the misleading error message Module jest-preset-angular should have "jest-preset.js" or "jest-preset.json" file at the root. is displayed.

Inspired by thymikee/jest-preset-angular#230, kudos to @thymikee

Test plan

Unit test added

@wtho wtho force-pushed the feat/print-stack-preset-error branch from 962eb19 to 58ca8d6 Compare February 19, 2019 15:10
@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

Copy link
Collaborator

@thymikee thymikee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Mind adding a changelog entry? :)

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@wtho wtho force-pushed the feat/print-stack-preset-error branch from 58ca8d6 to e4ec36b Compare February 19, 2019 16:00
@wtho
Copy link
Contributor Author

wtho commented Feb 19, 2019

Update: Changed test Regex /---.*---/s to /---[\s\S]*---/ so they also run in node v6.

Is the changelog entry ok?

@wtho
Copy link
Contributor Author

wtho commented Feb 19, 2019

Update 2: Simplified expected error message, as node v6 stacktraces it differently

@wtho wtho force-pushed the feat/print-stack-preset-error branch from e4ec36b to 0d8e9fa Compare February 19, 2019 16:21
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants