Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes the jest-haste-map mapper option #8299

Merged
merged 2 commits into from
Apr 10, 2019
Merged

Conversation

arcanis
Copy link
Contributor

@arcanis arcanis commented Apr 10, 2019

Summary

I forgot in my previous PR to forward the mapper option from the JestHasteMap options to the crawler option. It went unnoticed because the tests directly instantiate the crawler and because in Metro this logic wasn't necessary because the PnP resolution bypassed the Haste map.

I noticed the problem by removing this bypass, which highlighted that the mapper never got called 😞

Test plan

Modified my Jest copy locally, checked that the mapper was called as it should be.

@codecov-io
Copy link

Codecov Report

Merging #8299 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #8299   +/-   ##
======================================
  Coverage    62.2%   62.2%           
======================================
  Files         266     266           
  Lines       10673   10673           
  Branches     2595    2595           
======================================
  Hits         6639    6639           
  Misses       3445    3445           
  Partials      589     589
Impacted Files Coverage Δ
packages/jest-haste-map/src/index.ts 81.26% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 151c961...525b0da. Read the comment docs.

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants