expect: Improve report when matcher fails, part 17 #8349
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
For
toHaveProperty
matcher:rejects
orresolves
in matcher hintpass must be initialized
error withexpected path must not be an empty array
When negative assertion fails:
not
between expected label and valueWhen positive assertion fails:
Difference
label) or stringify values, not bothResidue:
getPath
as iterative algorithm and always returnhasEndProp
Test plan
Snapshots for
toHaveProperty
error
fail
pass
See also pictures in following comment.
Example pictures baseline at left and improved at right