Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set default display name color based on runner #8689

Merged
merged 1 commit into from
Aug 22, 2019

Conversation

jeysal
Copy link
Contributor

@jeysal jeysal commented Jul 15, 2019

Summary

Follow up to @natealcedo's #8025, automatically generating reasonable defaults for that feature.

BREAKING CHANGE:
See comment that was removed. Looks like it'll have to wait until 25 :|

TODO add changelog when there's a section to put it in without having to rebase ;)

Test plan

Added normalize tests. Tried on work project, tests are white, lints are green :)

@jeysal jeysal added this to the Jest 25 milestone Jul 15, 2019
@jeysal jeysal force-pushed the displayname-default-color branch from 3bb8607 to 651a802 Compare July 15, 2019 07:47
Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing changelog, but code lgtm

packages/jest-config/src/normalize.ts Outdated Show resolved Hide resolved
packages/jest-config/src/normalize.ts Show resolved Hide resolved
@jeysal jeysal force-pushed the displayname-default-color branch from 651a802 to 17e55ac Compare July 15, 2019 21:33
@jeysal
Copy link
Contributor Author

jeysal commented Jul 15, 2019

Incorporated review feedback. Intentionally didn't add changelog yet, will do so once we can actually land breaking changes :)

@thymikee thymikee changed the base branch from master to next August 19, 2019 19:35
@SimenB
Copy link
Member

SimenB commented Aug 21, 2019

@jeysal mind rebasing on the next branch and add the changelog entry?

@jeysal
Copy link
Contributor Author

jeysal commented Aug 21, 2019

@SimenB done :) should be good to go I think, manually tested it again

BREAKING CHANGE:
changes the internal config format for certain user-provided configs
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants