jest-diff: Do not inverse format if line consists of one change #8903
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
It distracts attention of reviewer if entire change line has inverse format
Test plan
Updated snapshots:
Realistic regression tests for the win: the code change was more subtle than I thought
Example pictures baseline at left and improved at right
The inverse lines fight for attention with the substrings within lines:
The inverse lines add insult to injury
when cleanup merges:from
andto
into changes because commono
is chaffTo set the record straight, merging
o
chaff intofrom
andto
changes is good cleanup. The problem is the length criterion where common substring'change '.length
does not have greater length than adjacent change substring'delete\n'.length
so is merged into changes.Notice the effect of one character increase in length to
'changed '