expect, jest-matcher-utils: Display change counts in annotation lines #9035
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In the
printDiffOrStringify
function, addincludeChangeCounts
option to calls:diffStringsUnified
diffDefault
For consistency with #8982 to interpret differences when other assertions fail
Residue
Did not add
includeChangeCounts
option:diff
named export fromjest-matcher-utils
but caller can add itI noticed something brittle about a few snapshots of matcher errors which contain diffs: when I tested with
--expand
option to see all of the lines in the snapshot to count changes, it affected the matcher, which is not correct.Test plan
Updated 76 snapshots
The differences between empty and non-empty map or object are example where change counts would be even clearer in a data-driven-diff
e2e
failures
expect
extend
expect
matchers
expect
toThrowMatchers
jest-matcher-utils
index
jest-matcher-utils
printDiffOrStringify
See also pictures in following comment: baseline is at left and improved is at right