jest-diff: Rename some new options and change their default values #9077
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Split and rename
trailingSpaceFormatter
option as prerequisite to improve snapshot colors:changeLineTrailingSpaceColor
becauseaColor
andbColor
might have background colorcommonLineTrailingSpaceColor
becausedim
does not modify like other colorsRename
firstOrLastEmptyLineReplacement
asemptyFirstOrLastLinePlaceholder
Change default values so dependents can turn them on instead of need to turn them off (not breaking, because the new options have not yet been published)
Edit
README.md
table and examples of new optionsProvide explicit values for these options in
jest-matcher-utils
andjest-snapshot
Export
DiffOptionsColor
type sojest-snapshot
can declaregetSnapshotColor
andgetReceivedColor
with conditional expression ofchalk.level
to return improved colorsTest plan
In
jest-diff
package:diff.test.ts
add 1 test and update 2 tests fortrailingSpaceFormatter
joinAlignedDiffs.test.ts
addemptyFirstOrLastLinePlaceholder
which affects 3 tests