feat: add buildDefaultResolverRequire
#9194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Once merged this can replace the following: i.e /cc @M4rk9696 |
Codecov Report
@@ Coverage Diff @@
## master #9194 +/- ##
==========================================
- Coverage 65.1% 65.06% -0.05%
==========================================
Files 278 278
Lines 11860 11865 +5
Branches 2923 2925 +2
==========================================
- Hits 7722 7720 -2
- Misses 3511 3517 +6
- Partials 627 628 +1
Continue to review full report at Codecov.
|
SimenB
reviewed
Nov 16, 2019
SimenB
approved these changes
Nov 16, 2019
SimenB
approved these changes
Nov 23, 2019
SimenB
changed the title
buildDefaultResolverRequire functionbuildDefaultResolverRequire
This was referenced Jan 28, 2020
This was referenced Feb 4, 2020
This was referenced Feb 18, 2020
This was referenced Mar 3, 2020
This was referenced Mar 10, 2020
This was referenced Mar 24, 2020
This was referenced Apr 16, 2020
This was referenced Apr 30, 2020
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a breaking out of
buildDefaultResolverRequirefrom #8829 as requested@SimenB I've not written tests or add an entry in the changelog as it seemed like a bit of overkill for something that is going to be used in future PRs.
I did a sweep of the codebase, and the only place this could actually be used right now is in
jest-core, but that'd require implementing support for the callback parameters 🤷♀It'll be nice to trim down the transformer PRs a bit :)