Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not default coverageProvider in yargs #9562

Merged
merged 1 commit into from
Feb 11, 2020

Conversation

SimenB
Copy link
Member

@SimenB SimenB commented Feb 11, 2020

Summary

Fixed #9561

We default in normalize and since argv overwrites config from file the default from argv always won. Now we'll default from Defaults instead - so still babel by default out of normalize, but now possible to set coverageProvider in config

Test plan

Verified manually 😅

@drew-gross
Copy link

Codecov Report

Merging #9562 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9562      +/-   ##
==========================================
- Coverage   65.05%   65.04%   -0.02%     
==========================================
  Files         286      286              
  Lines       12123    12123              
  Branches     3004     3004              
==========================================
- Hits         7887     7885       -2     
- Misses       3599     3600       +1     
- Partials      637      638       +1     
Impacted Files Coverage Δ
packages/expect/src/utils.ts 94.96% <0.00%> (-1.26%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3bfc33...edb6c3b. Read the comment docs.

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong behavior with CLI option coverageProvider v8 and broken cobertura report
3 participants