fix: ensure all packages correctly downlevel TS files #9715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimenB
commented
Mar 26, 2020
| @@ -51,7 +51,8 @@ export default class CustomConsole extends Console { | |||
| ); | |||
| } | |||
|
|
|||
| assert(value: unknown, message?: string | Error): asserts value { | |||
| // use `asserts` when https://github.com/sandersn/downlevel-dts/issues/32 is fixed | |||
| assert(value: unknown, message?: string | Error): void { | |||
There was a problem hiding this comment.
void matches the node core types as well, so should be fine
|
I've tried adding a test now that actually runs EDIT: OK, it failed. Fixing the error and pushing now EDIT2: yay, it passed |
This was referenced Apr 19, 2020
This was referenced Apr 30, 2020
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In #9705 I just tested with
pretty-format- seems I forgot to update a fewpackage.jsons. This also uncovered a few missingtypesfields as well, so fixing those at the same time.I also rolled back on syntax that downlevel doesn't support and worked around another bug.
Fixes #9714.
Test plan
I've now verified
typescript@3.4can compile the entirejestpackage, not justpretty-formatand what that pulls in