Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(jest-each) Throws an error when too much arguments are passed #9818

Merged
merged 2 commits into from
Apr 15, 2020

Conversation

ghostd
Copy link
Contributor

@ghostd ghostd commented Apr 15, 2020

Hi,

Should fix #9506

Regards

@facebook-github-bot
Copy link
Contributor

Hi @ghostd!

Thank you for your pull request and welcome to our community.We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@ghostd
Copy link
Contributor Author

ghostd commented Apr 15, 2020

CLA signed

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! A quick changelog entry and this should be good to go 🙂

@ghostd
Copy link
Contributor Author

ghostd commented Apr 15, 2020

Changelog entry added. All should be good :)

@SimenB SimenB merged commit c37abc2 into jestjs:master Apr 15, 2020
@SimenB
Copy link
Member

SimenB commented Apr 15, 2020

Thanks @ghostd!

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
@ghostd ghostd deleted the issue-gh-9506 branch May 11, 2021 18:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests marked with each are not added in total count
3 participants