Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused dependency node-dir #604

Closed
trivikr opened this issue Jul 15, 2024 · 0 comments · Fixed by #605
Closed

Remove unused dependency node-dir #604

trivikr opened this issue Jul 15, 2024 · 0 comments · Fixed by #605

Comments

@trivikr
Copy link
Contributor

trivikr commented Jul 15, 2024

Is your feature request related to a problem? Please describe.

I noticed that node-dir dependency was added in #24

It was removed from the source code in #92 while refactoring dir.files, but it was not removed from package.json dependencies.

A search on source code does not show the dependency being used https://github.com/search?q=repo%3Afacebook%2Fjscodeshift%20node-dir&type=code

Describe the solution you'd like

Remove unused dependency node-dir

Additional context

Cleaning up, just like in 89211fa

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant