Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing jar for version 0.51 #491

Closed
darioseidl opened this issue Jul 4, 2024 · 4 comments
Closed

Missing jar for version 0.51 #491

darioseidl opened this issue Jul 4, 2024 · 4 comments

Comments

@darioseidl
Copy link

I recently adopted ktfmt and wanted to download the latest version, but the jar files linked in release 0.51 are from version 0.50 instead of 0.51.

Btw. The motivation to use ktfmt was to have no more formatting decisions and consistent formatting in different editors.
It's great in theory, but at the moment, because of this issue #490, version 0.50 and 0.51 result in very different formatting. The IntelliJ plugin already uses 0.51, but when we adopted ktfmt we formatted the code with 0.50, and we want to keep trailing spaces.
It would be great, if v1.0 could be released with support for managing trailing spaces (enabled by default, afaiu?).
It would be even better, if ktfmt-gradle and the ktfmt IntelliJ plugin would allow specifying which version of ktfmt to use, to ensure that all tools use the same version of ktfmt.

@hick209
Copy link
Contributor

hick209 commented Aug 13, 2024

Thanks for flagging the wrong jars, I've just fixed it.

Regarding the bug in the formatting, this should be fixed in 0.52 and it will also come with trailing comma management turned on (glimpse from 1.0).

Thanks for using ktfmt and thank you even more for flagging issues to us. Sorry that it took some time to get back to you on this one here, I was busy trying to ship Kotlin 2.0 for the organization.

@hick209 hick209 closed this as completed Aug 13, 2024
@hick209
Copy link
Contributor

hick209 commented Aug 13, 2024

v0.52 should come out later this week BTW

@sureshg
Copy link

sureshg commented Aug 14, 2024

@hick209 0.51 has some compatibility issue with spotless plugin. Any idea when the spotless plugin changes will be released?

@hick209
Copy link
Contributor

hick209 commented Aug 14, 2024

@sureshg unfortunately I don't have visibility into that. I have fixed the compatibility issues, but they are not even on the 7.0 beta yet according to https://github.com/diffplug/spotless/blob/main/plugin-gradle/CHANGES.md 😕

Maybe worth opening an issue there regarding that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants