Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests for preserving comments in outputs when minify: false fail when using the latest version of @react-native/babel-preset #1383

Open
vzaidman opened this issue Nov 7, 2024 · 0 comments

Comments

@vzaidman
Copy link
Contributor

vzaidman commented Nov 7, 2024

Nightly tests for preserving comments in outputs when minify: false when using the latest version of @react-native/babel-preset are now failing since Oct 24 when React Native v0.76 was released.

This happens because facebook/react-native#46601 made babel-plugin-syntax-hermes-parser a default plugin in @react-native/babel-preset.

This is caused by the open issue facebook/hermes#1098 where babel-plugin-syntax-hermes-parser always strips comments from any code that passes through it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant