Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Metro fails when dependencies are installed with PNPM #231

Open
aleclarson opened this issue Aug 24, 2018 · 0 comments
Open

Metro fails when dependencies are installed with PNPM #231

aleclarson opened this issue Aug 24, 2018 · 0 comments

Comments

@aleclarson
Copy link
Contributor

aleclarson commented Aug 24, 2018 •
edited
Loading

Do you want to request a feature or report a bug?

bug 🐛

 

What is the current behavior?

Module resolution fails when dependency is installed using PNPM, because symlinks are heavily utilized.

(only tested with the Watchman crawler)

 

If the current behavior is a bug, please provide the steps to reproduce and a minimal repository on GitHub that we can yarn install and yarn test.

Link to repro

 

What is the expected behavior?

Metro should be aware of symlinks in node_modules whose "real path" contains a package.json and use this information to resolve dependencies.

 

Please provide your exact Metro configuration and mention your Metro, node, yarn/npm version and operating system.

  • metro v0.43.6
  • node v10.9.0
  • pnpm v2.13.5
  • macOS v10.13.6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@aleclarson