Skip to content

Commit 1476c29

Browse files
anirbanr-fbanirbanr-fb
committed
Moving Latency histograms to scaled widths
Summary: WIP: Still working on cleaning up some unit tests. Took the current implementation and shifted it from a uniform scale to a log scale. The scaling factor is baked in at 2.0 right now, but we can make it configurable in the future. If the step size is 100us, the latency histogram ranges would be 0-100us 100us-300us 300us-700us 700us-1500us and so on Test Plan: Ran all the tests, created some databases and did SHOW STATUS Reviewers: tianx, santoshb Reviewed By: santoshb Subscribers: webscalesql-eng Differential Revision: https://reviews.facebook.net/D61221
1 parent f2f2edf commit 1476c29

9 files changed

+363
-430
lines changed

Diff for: ‎mysql-test/suite/binlog/r/binlog_histogram_show_global_status.result

+9-14
Original file line numberDiff line numberDiff line change
@@ -1,20 +1,15 @@
11
SHOW GLOBAL STATUS LIKE "%histogram%binlog%";
22
Variable_name Value
33
Latency_histogram_binlog_fsync_0-1200ms COUNT
4-
Latency_histogram_binlog_fsync_1200-2400ms COUNT
5-
Latency_histogram_binlog_fsync_2400-3600ms COUNT
6-
Latency_histogram_binlog_fsync_3600-4800ms COUNT
7-
Latency_histogram_binlog_fsync_4800-6000ms COUNT
8-
Latency_histogram_binlog_fsync_6000-7200ms COUNT
9-
Latency_histogram_binlog_fsync_7200-8400ms COUNT
10-
Latency_histogram_binlog_fsync_8400-9600ms COUNT
11-
Latency_histogram_binlog_fsync_9600-10800ms COUNT
12-
Latency_histogram_binlog_fsync_10800-12000ms COUNT
13-
Latency_histogram_binlog_fsync_12000-13200ms COUNT
14-
Latency_histogram_binlog_fsync_13200-14400ms COUNT
15-
Latency_histogram_binlog_fsync_14400-15600ms COUNT
16-
Latency_histogram_binlog_fsync_15600-16800ms COUNT
17-
Latency_histogram_binlog_fsync_16800-18000ms COUNT
4+
Latency_histogram_binlog_fsync_1200-3600ms COUNT
5+
Latency_histogram_binlog_fsync_3600-8400ms COUNT
6+
Latency_histogram_binlog_fsync_8400-18000ms COUNT
7+
Latency_histogram_binlog_fsync_18000-37200ms COUNT
8+
Latency_histogram_binlog_fsync_37200-75600ms COUNT
9+
Latency_histogram_binlog_fsync_75600-152400ms COUNT
10+
Latency_histogram_binlog_fsync_152400-306000ms COUNT
11+
Latency_histogram_binlog_fsync_306000-613200ms COUNT
12+
Latency_histogram_binlog_fsync_613200-1227600ms COUNT
1813
histogram_binlog_group_commit_0-1 COUNT
1914
histogram_binlog_group_commit_1-2 COUNT
2015
histogram_binlog_group_commit_2-3 COUNT

Diff for: ‎mysql-test/suite/innodb/r/innodb_histogram_check_zero_step_size.result

+80-120
Original file line numberDiff line numberDiff line change
@@ -1,139 +1,99 @@
11
Histograms:
22

33
Async Reads
4-
Bucket 0 to 0 us 0
5-
Bucket 0 to 0 us 0
6-
Bucket 0 to 0 us 0
7-
Bucket 0 to 0 us 0
8-
Bucket 0 to 0 us 0
9-
Bucket 0 to 0 us 0
10-
Bucket 0 to 0 us 0
11-
Bucket 0 to 0 us 0
12-
Bucket 0 to 0 us 0
13-
Bucket 0 to 0 us 0
14-
Bucket 0 to 0 us 0
15-
Bucket 0 to 0 us 0
16-
Bucket 0 to 0 us 0
17-
Bucket 0 to 0 us 0
18-
Bucket 0 to 0 us 0
4+
Bucket 0 to 0 ms 0
5+
Bucket 0 to 0 ms 0
6+
Bucket 0 to 0 ms 0
7+
Bucket 0 to 0 ms 0
8+
Bucket 0 to 0 ms 0
9+
Bucket 0 to 0 ms 0
10+
Bucket 0 to 0 ms 0
11+
Bucket 0 to 0 ms 0
12+
Bucket 0 to 0 ms 0
13+
Bucket 0 to 0 ms 0
1914

2015
Async Writes
21-
Bucket 0 to 0 us 0
22-
Bucket 0 to 0 us 0
23-
Bucket 0 to 0 us 0
24-
Bucket 0 to 0 us 0
25-
Bucket 0 to 0 us 0
26-
Bucket 0 to 0 us 0
27-
Bucket 0 to 0 us 0
28-
Bucket 0 to 0 us 0
29-
Bucket 0 to 0 us 0
30-
Bucket 0 to 0 us 0
31-
Bucket 0 to 0 us 0
32-
Bucket 0 to 0 us 0
33-
Bucket 0 to 0 us 0
34-
Bucket 0 to 0 us 0
35-
Bucket 0 to 0 us 0
16+
Bucket 0 to 0 ms 0
17+
Bucket 0 to 0 ms 0
18+
Bucket 0 to 0 ms 0
19+
Bucket 0 to 0 ms 0
20+
Bucket 0 to 0 ms 0
21+
Bucket 0 to 0 ms 0
22+
Bucket 0 to 0 ms 0
23+
Bucket 0 to 0 ms 0
24+
Bucket 0 to 0 ms 0
25+
Bucket 0 to 0 ms 0
3626

3727
Sync Reads
38-
Bucket 0 to 0 us 0
39-
Bucket 0 to 0 us 0
40-
Bucket 0 to 0 us 0
41-
Bucket 0 to 0 us 0
42-
Bucket 0 to 0 us 0
43-
Bucket 0 to 0 us 0
44-
Bucket 0 to 0 us 0
45-
Bucket 0 to 0 us 0
46-
Bucket 0 to 0 us 0
47-
Bucket 0 to 0 us 0
48-
Bucket 0 to 0 us 0
49-
Bucket 0 to 0 us 0
50-
Bucket 0 to 0 us 0
51-
Bucket 0 to 0 us 0
52-
Bucket 0 to 0 us 0
28+
Bucket 0 to 0 ms 0
29+
Bucket 0 to 0 ms 0
30+
Bucket 0 to 0 ms 0
31+
Bucket 0 to 0 ms 0
32+
Bucket 0 to 0 ms 0
33+
Bucket 0 to 0 ms 0
34+
Bucket 0 to 0 ms 0
35+
Bucket 0 to 0 ms 0
36+
Bucket 0 to 0 ms 0
37+
Bucket 0 to 0 ms 0
5338

5439
Sync Writes
55-
Bucket 0 to 0 us 0
56-
Bucket 0 to 0 us 0
57-
Bucket 0 to 0 us 0
58-
Bucket 0 to 0 us 0
59-
Bucket 0 to 0 us 0
60-
Bucket 0 to 0 us 0
61-
Bucket 0 to 0 us 0
62-
Bucket 0 to 0 us 0
63-
Bucket 0 to 0 us 0
64-
Bucket 0 to 0 us 0
65-
Bucket 0 to 0 us 0
66-
Bucket 0 to 0 us 0
67-
Bucket 0 to 0 us 0
68-
Bucket 0 to 0 us 0
69-
Bucket 0 to 0 us 0
40+
Bucket 0 to 0 ms 0
41+
Bucket 0 to 0 ms 0
42+
Bucket 0 to 0 ms 0
43+
Bucket 0 to 0 ms 0
44+
Bucket 0 to 0 ms 0
45+
Bucket 0 to 0 ms 0
46+
Bucket 0 to 0 ms 0
47+
Bucket 0 to 0 ms 0
48+
Bucket 0 to 0 ms 0
49+
Bucket 0 to 0 ms 0
7050

7151
Log Writes
72-
Bucket 0 to 0 us 0
73-
Bucket 0 to 0 us 0
74-
Bucket 0 to 0 us 0
75-
Bucket 0 to 0 us 0
76-
Bucket 0 to 0 us 0
77-
Bucket 0 to 0 us 0
78-
Bucket 0 to 0 us 0
79-
Bucket 0 to 0 us 0
80-
Bucket 0 to 0 us 0
81-
Bucket 0 to 0 us 0
82-
Bucket 0 to 0 us 0
83-
Bucket 0 to 0 us 0
84-
Bucket 0 to 0 us 0
85-
Bucket 0 to 0 us 0
86-
Bucket 0 to 0 us 0
52+
Bucket 0 to 0 ms 0
53+
Bucket 0 to 0 ms 0
54+
Bucket 0 to 0 ms 0
55+
Bucket 0 to 0 ms 0
56+
Bucket 0 to 0 ms 0
57+
Bucket 0 to 0 ms 0
58+
Bucket 0 to 0 ms 0
59+
Bucket 0 to 0 ms 0
60+
Bucket 0 to 0 ms 0
61+
Bucket 0 to 0 ms 0
8762

8863
Double Buffer Writes
89-
Bucket 0 to 0 us 0
90-
Bucket 0 to 0 us 0
91-
Bucket 0 to 0 us 0
92-
Bucket 0 to 0 us 0
93-
Bucket 0 to 0 us 0
94-
Bucket 0 to 0 us 0
95-
Bucket 0 to 0 us 0
96-
Bucket 0 to 0 us 0
97-
Bucket 0 to 0 us 0
98-
Bucket 0 to 0 us 0
99-
Bucket 0 to 0 us 0
100-
Bucket 0 to 0 us 0
101-
Bucket 0 to 0 us 0
102-
Bucket 0 to 0 us 0
103-
Bucket 0 to 0 us 0
64+
Bucket 0 to 0 ms 0
65+
Bucket 0 to 0 ms 0
66+
Bucket 0 to 0 ms 0
67+
Bucket 0 to 0 ms 0
68+
Bucket 0 to 0 ms 0
69+
Bucket 0 to 0 ms 0
70+
Bucket 0 to 0 ms 0
71+
Bucket 0 to 0 ms 0
72+
Bucket 0 to 0 ms 0
73+
Bucket 0 to 0 ms 0
10474

10575
File Flush Time
106-
Bucket 0 to 0 us 0
107-
Bucket 0 to 0 us 0
108-
Bucket 0 to 0 us 0
109-
Bucket 0 to 0 us 0
110-
Bucket 0 to 0 us 0
111-
Bucket 0 to 0 us 0
112-
Bucket 0 to 0 us 0
113-
Bucket 0 to 0 us 0
114-
Bucket 0 to 0 us 0
115-
Bucket 0 to 0 us 0
116-
Bucket 0 to 0 us 0
117-
Bucket 0 to 0 us 0
118-
Bucket 0 to 0 us 0
119-
Bucket 0 to 0 us 0
120-
Bucket 0 to 0 us 0
76+
Bucket 0 to 0 ms 0
77+
Bucket 0 to 0 ms 0
78+
Bucket 0 to 0 ms 0
79+
Bucket 0 to 0 ms 0
80+
Bucket 0 to 0 ms 0
81+
Bucket 0 to 0 ms 0
82+
Bucket 0 to 0 ms 0
83+
Bucket 0 to 0 ms 0
84+
Bucket 0 to 0 ms 0
85+
Bucket 0 to 0 ms 0
12186

12287
Fsyncs
123-
Bucket 0 to 0 us 0
124-
Bucket 0 to 0 us 0
125-
Bucket 0 to 0 us 0
126-
Bucket 0 to 0 us 0
127-
Bucket 0 to 0 us 0
128-
Bucket 0 to 0 us 0
129-
Bucket 0 to 0 us 0
130-
Bucket 0 to 0 us 0
131-
Bucket 0 to 0 us 0
132-
Bucket 0 to 0 us 0
133-
Bucket 0 to 0 us 0
134-
Bucket 0 to 0 us 0
135-
Bucket 0 to 0 us 0
136-
Bucket 0 to 0 us 0
137-
Bucket 0 to 0 us 0
88+
Bucket 0 to 0 ms 0
89+
Bucket 0 to 0 ms 0
90+
Bucket 0 to 0 ms 0
91+
Bucket 0 to 0 ms 0
92+
Bucket 0 to 0 ms 0
93+
Bucket 0 to 0 ms 0
94+
Bucket 0 to 0 ms 0
95+
Bucket 0 to 0 ms 0
96+
Bucket 0 to 0 ms 0
97+
Bucket 0 to 0 ms 0
13898
--------------
13999
Done

0 commit comments

Comments
 (0)