Skip to content

Commit ee92950

Browse files
abal147facebook-github-bot
authored andcommitted
Unconditionally send gtid in SHOW BINARY LOGS WITH GTID
Summary: When the gtid is empty, nothing is sent over the wire to the client. This was causing memory issues client side because the client expects a fixed number of columns per row, and nothing was being sent. Fix is to send an empty string in it's place. squash with: 25fec83 Reviewed By: lth Differential Revision: D4812840 fbshipit-source-id: 103dd4e
1 parent 86e7a21 commit ee92950

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

sql/rpl_master.cc

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2712,6 +2712,8 @@ bool show_binlogs(THD* thd, bool with_gtid)
27122712
gtid_set.to_string(&buf, &Gtid_set::commented_string_format);
27132713
protocol->store(buf, strlen(buf), &my_charset_bin);
27142714
free(buf);
2715+
} else {
2716+
protocol->store("", 0, &my_charset_bin);
27152717
}
27162718
}
27172719

0 commit comments

Comments
 (0)