Remove unnecessary point conversion

daxpedda · daxpedda · commit bd7193b7fe6b · 2023-04-02T18:15:36.000+02:00
diff --git a/Cargo.toml b/Cargo.toml
@@ -13,7 +13,7 @@ version = "3.0.0-pre.2"
 
 [features]
 argon2 = ["dep:argon2"]
-curve25519 = ["dep:curve25519-dalek", "curve25519-dalek?/precomputed-tables"]
+curve25519 = ["dep:curve25519-dalek"]
 default = ["ristretto255-voprf", "serde"]
 ristretto255 = ["dep:curve25519-dalek", "voprf/ristretto255"]
 ristretto255-voprf = ["ristretto255", "voprf/ristretto255-ciphersuite"]
diff --git a/src/key_exchange/group/curve25519.rs b/src/key_exchange/group/curve25519.rs
@@ -7,7 +7,7 @@
 
 //! Key Exchange group implementation for Curve25519
 
-use curve25519_dalek::constants::ED25519_BASEPOINT_TABLE;
+use curve25519_dalek::constants::X25519_BASEPOINT;
 use curve25519_dalek::montgomery::MontgomeryPoint;
 use curve25519_dalek::scalar::Scalar;
 use curve25519_dalek::traits::Identity;
@@ -83,7 +83,7 @@ impl KeGroup for Curve25519 {
     }
 
     fn public_key(sk: Self::Sk) -> Self::Pk {
-        (ED25519_BASEPOINT_TABLE * &sk).to_montgomery()
+        X25519_BASEPOINT * sk
     }
 
     fn diffie_hellman(pk: Self::Pk, sk: Self::Sk) -> GenericArray<u8, Self::PkLen> {

Original file line number	Diff line number	Diff line change
`@@ -7,7 +7,7 @@`
`7`	`7`
`8`	`8`	`//! Key Exchange group implementation for Curve25519`
`9`	`9`
`10`		`-use curve25519_dalek::constants::ED25519_BASEPOINT_TABLE;`
	`10`	`+use curve25519_dalek::constants::X25519_BASEPOINT;`
`11`	`11`	`use curve25519_dalek::montgomery::MontgomeryPoint;`
`12`	`12`	`use curve25519_dalek::scalar::Scalar;`
`13`	`13`	`use curve25519_dalek::traits::Identity;`
`@@ -83,7 +83,7 @@ impl KeGroup for Curve25519 {`
`83`	`83`	`}`
`84`	`84`
`85`	`85`	`fn public_key(sk: Self::Sk) -> Self::Pk {`
`86`		`- (ED25519_BASEPOINT_TABLE * &sk).to_montgomery()`
	`86`	`+ X25519_BASEPOINT * sk`
`87`	`87`	`}`
`88`	`88`
`89`	`89`	`fn diffie_hellman(pk: Self::Pk, sk: Self::Sk) -> GenericArray<u8, Self::PkLen> {`