Set HeaderContentValidation error in HQStreamCodec

Summary: Setting the new HeaderContentValidation ProxygenError enum in HQStreamCodec wherever there's a header validation error. These errors should now be recorded separately from header parsing errors.

Reviewed By: afrind

Differential Revision: D70342834

fbshipit-source-id: e95f1fc8552e2a2fe78750652871f16536dc62db

Author: Joanna Jo

proxygen/lib/http/codec/HQStreamCodec.cpp

@@ -209,7 +209,7 @@ void HQStreamCodec::onHeadersComplete(HTTPHeaderSize decodedSize,
     } else {
       err.setHttpStatusCode(400);
     }
-    err.setProxygenError(kErrorParseHeader);
+    err.setProxygenError(decodeInfo_.proxygenError.value_or(kErrorParseHeader));
     // Have to clone it
     err.setPartialMsg(std::make_unique<HTTPMessage>(*decodeInfo_.msg));
     callback_->onError(streamId_, err, true);

proxygen/lib/http/codec/test/HQCodecTest.cpp

@@ -813,7 +813,8 @@ TEST_F(HQCodecTest, HighAscii) {
   EXPECT_EQ(callbacks_.headersComplete, 0);
   EXPECT_EQ(callbacks_.messageComplete, 0);
   EXPECT_EQ(callbacks_.streamErrors, 4);
-  EXPECT_EQ(callbacks_.lastParseError->getProxygenError(), kErrorParseHeader);
+  EXPECT_EQ(callbacks_.lastParseError->getProxygenError(),
+            kErrorHeaderContentValidation);
   EXPECT_EQ(callbacks_.sessionErrors, 0);
   callbacks_.reset();
 
@@ -832,7 +833,8 @@ TEST_F(HQCodecTest, HighAscii) {
   EXPECT_EQ(callbacks_.headersComplete, 1);
   EXPECT_EQ(callbacks_.messageComplete, 0);
   EXPECT_EQ(callbacks_.streamErrors, 1);
-  EXPECT_EQ(callbacks_.lastParseError->getProxygenError(), kErrorParseHeader);
+  EXPECT_EQ(callbacks_.lastParseError->getProxygenError(),
+            kErrorHeaderContentValidation);
   EXPECT_EQ(callbacks_.sessionErrors, 0);
 }