Skip to content

Commit 9b3b4e2

Browse files
Joanna Jofacebook-github-bot
Joanna Jo
authored andcommitted
Change to debug logging for header values
Summary: Changing to debug logging for HTTP header values due to privacy implications. Reviewed By: hanidamlaj Differential Revision: D70581133 fbshipit-source-id: 66ff86702d9b45717d2af8df4f1debe7b85058c2
1 parent 254a6b0 commit 9b3b4e2

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

proxygen/lib/http/codec/HQStreamCodec.cpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -196,7 +196,7 @@ void HQStreamCodec::onHeadersComplete(HTTPHeaderSize decodedSize,
196196
LOG(ERROR) << "Failed parsing header list for stream=" << streamId_
197197
<< ", error=" << decodeInfo_.parsingError;
198198
if (!decodeInfo_.headerErrorValue.empty()) {
199-
std::cerr << " value=" << decodeInfo_.headerErrorValue << std::endl;
199+
DVLOG(4) << " value=" << decodeInfo_.headerErrorValue;
200200
}
201201
HTTPException err(
202202
HTTPException::Direction::INGRESS,

proxygen/lib/http/codec/HTTP1xCodec.cpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -908,7 +908,7 @@ bool HTTP1xCodec::pushHeaderNameAndValue(HTTPHeaders& hdrs) {
908908
compatValidate ? CodecUtil::CtlEscapeMode::STRICT_COMPAT
909909
: CodecUtil::CtlEscapeMode::STRICT)) {
910910
LOG(ERROR) << "Invalid header name=" << headerName;
911-
std::cerr << " value=" << currentHeaderValue_ << std::endl;
911+
DVLOG(4) << " value=" << currentHeaderValue_;
912912
return false;
913913
}
914914
}

proxygen/lib/http/codec/HTTP2Codec.cpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -622,7 +622,7 @@ HTTP2Codec::parseHeadersDecodeFrames(
622622
LOG(ERROR) << "Failed parsing header list for stream=" << curHeader_.stream
623623
<< ", error=" << decodeInfo_.parsingError;
624624
if (!decodeInfo_.headerErrorValue.empty()) {
625-
std::cerr << " value=" << decodeInfo_.headerErrorValue << std::endl;
625+
DVLOG(4) << " value=" << decodeInfo_.headerErrorValue;
626626
}
627627
VLOG(3) << "Header block="
628628
<< IOBufPrinter::printHexFolly(curHeaderBlock_.front(), true);

0 commit comments

Comments
 (0)