Pyre does not reason about if statements with logical operators

[bigfootjon]

Pyre Bug

Pyre does not reason about complex if statements. This is used in e.g. aiohttp:

https://github.com/aio-libs/aiohttp/blob/master/aiohttp/client.py#L1034

Reproduction steps

(try commenting and uncommenting the various options to see the various results)

Expected behavior
All of the above if statements should report a type error

Logs
See playground link

[bigfootjon]

Per discussion with @stroxler this code would need to be updated:

https://github.com/facebook/pyre-check/blob/main/source/analysis/preprocessing.ml#L4773-L4774

The likely solution is to switch to a replace-special-values-with-constant-true phase followed by a merge-logical-expressions-phase