Skip to content
This repository has been archived by the owner on Jun 26, 2020. It is now read-only.

☂️ Suspense umbrella task #1189

Closed
3 tasks
bvaughn opened this issue Oct 19, 2018 · 3 comments
Closed
3 tasks

☂️ Suspense umbrella task #1189

bvaughn opened this issue Oct 19, 2018 · 3 comments
Assignees
Labels

Comments

@bvaughn
Copy link
Contributor

bvaughn commented Oct 19, 2018

Misc

  • Keyboard navigation: Arrow key navigation for selected element is a bit broken. You can use down/right arrow to drill down into a Suspense component, but the up/left arrows won't drill back up. (It gets stuck at the component beneath Suspense.)
    arrowkey

Hiding timed-out children

facebook/react/pull/13823 changed the behavior of timed-out suspense trees. In order to preserve state (of both React components and host components) the timed-out tree now stays mounted, but gets hidden (e.g. "display: none").

For the GIF below, I used create-react-app with the following changes: https://gist.github.com/bvaughn/aab2a855c5fa1daa9ca55b1fdfac20a5

  • If the suspended subtree is expanded in the DevTools tree view, it gets auto-collapsed when it's hidden.
    collapse

  • The Profiler's render counter gets reset for all components in the hidden subtree. This makes it look like it's a new tree and might be confusing to people.

Testing

TODO @bvaughn and @acdlite will fill this in later.

@swyxio
Copy link

swyxio commented Nov 2, 2018

would this be a nice to have? #1141

@bvaughn
Copy link
Contributor Author

bvaughn commented Nov 2, 2018

Not sure. DevTools is already monstrously large. Don't know how I feel about adding more panels and increasing scope until/unless we tackle something like #1214

@bvaughn
Copy link
Contributor Author

bvaughn commented Nov 19, 2018

Fixes went out with 3.4.3

@bvaughn bvaughn closed this as completed Nov 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants