Skip to content
This repository has been archived by the owner on Jun 26, 2020. It is now read-only.

Releases and tags missing #1273

Closed
0xdevalias opened this issue Jan 15, 2019 · 6 comments
Closed

Releases and tags missing #1273

0xdevalias opened this issue Jan 15, 2019 · 6 comments

Comments

@0xdevalias
Copy link

0xdevalias commented Jan 15, 2019

(Ref: #1207 (comment))

Looks like there have been no releases since v3.4.2, and no git tags since v3.3.2, even though master seems to have commits naming versions up to v3.6 currently:

Was wondering when there is likely to be releases for these intermediary versions, and if the tags could also be updated to match.

Edit: It seems this also doesn't match what is live in the chrome store, as that version appears to be v6.0:

@0xdevalias 0xdevalias changed the title Releases and tags Releases and tags missing Jan 15, 2019
@bvaughn
Copy link
Contributor

bvaughn commented Jan 15, 2019

I don't think adding git tags for NPM releases is that important, personally.

@0xdevalias
Copy link
Author

0xdevalias commented Jan 15, 2019

It makes it nice when you're trying to track down if a commit has landed in a certain version, as the most immediate usecase. And if it's easily automatable/added to the 'deploy' scripts, then you kind of get it 'for free'.

This seems to have been raised previously, and according to the outcome of that issue, was accepted as 'we should do that':

Tags for releases from now on should show up.
#484 (comment)

@bvaughn
Copy link
Contributor

bvaughn commented Jan 15, 2019

There's no "deploy script" unfortunately. It's a pretty manual process.

I can try to remember to do this, but I make no promises.

@0xdevalias
Copy link
Author

0xdevalias commented Jan 16, 2019

Would it be worth wrapping up the process into a deploy/'release' script of sorts, save having to remember?

@bvaughn
Copy link
Contributor

bvaughn commented Jan 16, 2019

I still don't think tags are very valuable in this repo, so in my opinion– no.

@bvaughn
Copy link
Contributor

bvaughn commented Jan 16, 2019

Closing this for now.

I'll try to remember to git tag when I create releases.

@bvaughn bvaughn closed this as completed Jan 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants