Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Running on Device: LaunchScreen Storyboard #1837

Closed
hramos opened this issue Apr 9, 2020 · 6 comments
Closed

Running on Device: LaunchScreen Storyboard #1837

hramos opened this issue Apr 9, 2020 · 6 comments
Labels
📼 Outdated Docs Documentation is there, but outdated or wrong.

Comments

@hramos
Copy link
Contributor

hramos commented Apr 9, 2020

See facebook/react-native#28239 (comment) - we might need to update the docs to account for the new Storyboard based guidance.
@Simek Simek added the 📼 Outdated Docs Documentation is there, but outdated or wrong. label Apr 16, 2020
@gedeagas
Copy link
Contributor

Hi @Simek, is anyone working on this already? I would love to help if not.

@Simek
Copy link
Collaborator

Simek commented Apr 24, 2020 •
edited
Loading

Hi @gedeagas, awesome, feel free to work on this issue.

At the first glance it looks like that the docs are not mentioning XIBs anywhere (so the StoryBoard replacement is not required) but an extensive check is needed. Also if there is no information about Launch Screen already it would be nice to add few sentences about it.

@jeswinsimon
Copy link
Contributor

@Simek There is a section under pro tips on how to keep the Launch Screen visible during loading if the app bundle size is large. The code snippet in this section is no longer relevant as we are not using an XIB anymore.

@gedeagas
Copy link
Contributor

gedeagas commented Apr 24, 2020 •
edited
Loading

As @jeswinsimon explained, we are no longer using XIB for our SplashScreen. so loadNibNamed:@"LaunchScreen" will not work because the XIB file is no longer exist. I am planing to update the code to use Storyboard

@gedeagas
Copy link
Contributor

gedeagas commented Apr 29, 2020 •
edited
Loading

Working on it. sorry have been busy for the past month due to the pandemic

@gedeagas
Copy link
Contributor

@Simek can you close this, somebody already updated this page. #2031. quite busy for the past few months and can't land the pr :(

@Simek Simek closed this as completed Aug 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
📼 Outdated Docs Documentation is there, but outdated or wrong.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@hramos @Simek @jeswinsimon @gedeagas