-
Notifications
You must be signed in to change notification settings - Fork 24.4k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Make the
reactNativeArchitectures
property more discoverable
Summary: I've unified the function that is responsible of getting the `reactNativeArchitectures` property to a single one (ideally we could move it inside the Gradle Plugin in the future). I've also added a property in the `gradle.properties` file. This makes easier for users to customize the architecture to build without having to specify a CLI flag or edit multiple gradle files. Changelog: [Android] [Added] - Make the `reactNativeArchitectures` property more discoverable Reviewed By: ShikaSD Differential Revision: D32244997 fbshipit-source-id: 33180544400f9abe63e9b539ff16fefa17a024ba
- Loading branch information
1 parent
d70555f
commit 0f39a10
Showing
4 changed files
with
21 additions
and
8 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0f39a10
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
By the way idk if this is integrated with fb internal tooling, but here's the integration for the OSS CLI react-native-community/cli#1388
0f39a10
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@janicduplessis That's amazing, thanks for pointing out. I believe we need to update the CLI end to use
-PreactNativeArchitectures
instead of-PreactNativeDebugArchitectures
as the property has been renamed.0f39a10
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Working on updating RN to latest main today so will open a PR to fix the CLI. I think we can pass both values for now since 0.66 was released with
PreactNativeDebugArchitectures
.